Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix serve panics if splay is zero. #1217

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Conversation

preslavgerchev
Copy link
Contributor

Running cnspec serve with the following config (relevant bits only included):

scan_interval:
  timer: 60

panics as the splay is 0. This PR adds a safeguard to ensure cnspec doesn't panic if it's only the timer that has been set

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: Preslav <preslav@mondoo.com>
Copy link
Contributor

github-actions bot commented Apr 2, 2024

Test Results

  1 files  ±0   24 suites  ±0   18s ⏱️ ±0s
322 tests ±0  321 ✅ ±0  1 💤 ±0  0 ❌ ±0 
323 runs  ±0  322 ✅ ±0  1 💤 ±0  0 ❌ ±0 

Results for commit 88a9c48. ± Comparison against base commit eba0d80.

@preslavgerchev preslavgerchev merged commit 7d0f974 into main Apr 2, 2024
13 checks passed
@preslavgerchev preslavgerchev deleted the preslav/fix-zero-splay branch April 2, 2024 10:57
@github-actions github-actions bot locked and limited conversation to collaborators Apr 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants