Skip to content

Commit

Permalink
Merge pull request #5827 from BobZombie:feature/fix_d.ts
Browse files Browse the repository at this point in the history
[bugfix] ts: toISOString function also return null
  • Loading branch information
ichernev committed Dec 24, 2023
2 parents 8d46db8 + c6d2607 commit 651dff4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions moment.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ declare namespace moment {
clone(): Duration;

humanize(argWithSuffix?: boolean, argThresholds?: argThresholdOpts): string;

humanize(argThresholds?: argThresholdOpts): string;

abs(): Duration;
Expand Down Expand Up @@ -587,7 +587,7 @@ declare namespace moment {

toArray(): number[];
toDate(): Date;
toISOString(keepOffset?: boolean): string;
toISOString(keepOffset?: boolean): string | void; // null
inspect(): string;
toJSON(): string;
unix(): number;
Expand Down
4 changes: 2 additions & 2 deletions ts3.1-typings/moment.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ declare namespace moment {
clone(): Duration;

humanize(argWithSuffix?: boolean, argThresholds?: argThresholdOpts): string;

humanize(argThresholds?: argThresholdOpts): string;

abs(): Duration;
Expand Down Expand Up @@ -575,7 +575,7 @@ declare namespace moment {

toArray(): [number, number, number, number, number, number, number];
toDate(): Date;
toISOString(keepOffset?: boolean): string;
toISOString(keepOffset?: boolean): string | null;
inspect(): string;
toJSON(): string;
unix(): number;
Expand Down

0 comments on commit 651dff4

Please sign in to comment.