Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #139 - "Can't find license-maven-plugin" #348

Merged
merged 1 commit into from Aug 5, 2019

Conversation

AndyGee
Copy link
Contributor

@AndyGee AndyGee commented Aug 5, 2019

Use the PluginDescriptor.
Most painful checkstyle.

Copy link
Contributor

@ppalaga ppalaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

Besides the single inline comment, please add some simple integration test under src/it.

@ppalaga
Copy link
Contributor

ppalaga commented Aug 5, 2019

OK, now I see there is 0374cf4 that delivers the test coverage.

@AndyGee
Copy link
Contributor Author

AndyGee commented Aug 5, 2019

Hmm, not that simple it seems, without digging in, is there a step thad does magic on the invoker.properties?

@AndyGee
Copy link
Contributor Author

AndyGee commented Aug 5, 2019

That does it - no more build dep required for a command line - I'd not remove the legacy code in this request, but I'd agree it should be removed through new request/issue.

@AndyGee
Copy link
Contributor Author

AndyGee commented Aug 5, 2019

The CI jobs are actually passing, but need an update to go green.

@ppalaga
Copy link
Contributor

ppalaga commented Aug 5, 2019

I do not see the CI passing. I restarted Appveyor on Java 8 and I am investigating how to fix the broken Java installation in TravisCI.

@ppalaga
Copy link
Contributor

ppalaga commented Aug 5, 2019

The master is now passing the whole OS x Java version matrix. Could you please rebase and also squash into a single commit?

Use the PluginDescriptor.
Most painful checkstyle.

Update IT test to use no build dep and full coordinates

Use project coordinates
@AndyGee
Copy link
Contributor Author

AndyGee commented Aug 5, 2019

The CI is flaky

@ppalaga
Copy link
Contributor

ppalaga commented Aug 5, 2019

Yeah, the timeouts on Appveyor do not look good.

@ppalaga
Copy link
Contributor

ppalaga commented Aug 5, 2019

I cleaned the caches on TravisCI and restarted. Let's see if it helps.

@ppalaga ppalaga merged commit 01fd9a1 into mojohaus:master Aug 5, 2019
@ppalaga
Copy link
Contributor

ppalaga commented Aug 5, 2019

Maven Central timeouts seems to be the cause of the random failures on the CI. AppVeyor passed for this PR, TravisCI passed here: #350

@AndyGee AndyGee deleted the AndyGee-139 branch January 15, 2020 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants