Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #228 Add .gitattributes #344

Merged
merged 1 commit into from Jul 3, 2019
Merged

Fix #228 Add .gitattributes #344

merged 1 commit into from Jul 3, 2019

Conversation

kingle
Copy link
Contributor

@kingle kingle commented Jul 3, 2019

This worked for me to fix the build on Windows.

@ppalaga
Copy link
Contributor

ppalaga commented Jul 3, 2019

Very good @kingle , I wanted to see something as minimal as this. Let me check if it works on Linux too.

@kingle
Copy link
Contributor Author

kingle commented Jul 3, 2019

Note: for someone on Windows that pulls this update from an existing checkout -- the existence of this file doesn't automatically change anything in their current working directory. They will need to re-clone or git reset --hard for this to take.

@ppalaga
Copy link
Contributor

ppalaga commented Jul 3, 2019

What are the symptoms for needing to re-clone or git reset --hard? I wonder if we should put a note on that to the README?

@ppalaga ppalaga merged commit 60418bb into mojohaus:master Jul 3, 2019
@ppalaga
Copy link
Contributor

ppalaga commented Jul 3, 2019

Thanks, @kingle !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants