Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skip flags #186

Merged
merged 5 commits into from
Nov 19, 2023
Merged

Add skip flags #186

merged 5 commits into from
Nov 19, 2023

Conversation

hgschmie
Copy link
Contributor

@hgschmie hgschmie commented Sep 2, 2023

  • build-helper:add-source
  • build-helper:add-test-source
  • build-helper:add-resource
  • build-helper:add-test-resource

Add <skip>true|false</skip> to allow skipping plugin execution.

@slawekjaranowski
Copy link
Member

There is an issue #153

@slawekjaranowski
Copy link
Member

There is also skipAttach option for attach-artifact
https://www.mojohaus.org/build-helper-maven-plugin/attach-artifact-mojo.html#skipAttach

We can think if we want one name skip option for all goals.

We can also have two options - one global skip for all goals and specific one for each goals.

@hgschmie
Copy link
Contributor Author

hgschmie commented Sep 4, 2023

Screenshot 2023-09-03 at 22 17 08

github changed / rewrote the title of this commit. I wrote this all-lowercase. :-(

@slawekjaranowski
Copy link
Member

Screenshot 2023-09-03 at 22 17 08 github changed / rewrote the title of this commit. I wrote this all-lowercase. :-(

since is a user name on GitHub, so when we prefix with @ anywhere GitHub try to link to account 😄

@hgschmie
Copy link
Contributor Author

hgschmie commented Sep 5, 2023

You could just merge the PR(s) and then make the changes that you feel necessary yourself.

  • You asked me to add tests. I did that.
  • You asked me to change the property names. I did that.
  • Now you ask to make another change...

This is not an academic grading exercise where I am trying to get to a passing grade or something to be "acceptable". It is a contribution of a useful feature to a project that I did in my spare time trying to be helpful to the project. I already spent more time on this than I wanted. I am not spending more time.

If you feel that this is not "production ready" code, then you need someone that gets paid for it to get it to that level.

@slawekjaranowski slawekjaranowski self-assigned this Sep 20, 2023
@slawekjaranowski
Copy link
Member

@hgschmie tanks for your works ... I don't to examine you or offend you in any way.
Simply also I do a review in my spare free time and I can make a mistake.

I will care about this PR.

@slawekjaranowski slawekjaranowski linked an issue Nov 2, 2023 that may be closed by this pull request
- build-helper:add-source
- build-helper:add-test-source
- build-helper:add-resource
- build-helper:add-test-resource

Add `<skip>true|false</skip>` to allow skipping plugin execution.
Align with uptodate property / uptodate properties
@slawekjaranowski slawekjaranowski merged commit b49b7e6 into mojohaus:master Nov 19, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please provide a <skip> option for each goal.
2 participants