-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add skipIfMissing flag #187
Merged
Merged
+254
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
please add tests for new parameters |
Sure, but what is the point, given this:
|
src/main/java/org/codehaus/mojo/buildhelper/AbstractAddResourceMojo.java
Outdated
Show resolved
Hide resolved
|
src/main/java/org/codehaus/mojo/buildhelper/AddResourceMojo.java
Outdated
Show resolved
Hide resolved
Merged
- build-helper:add-source - build-helper:add-test-source - build-helper:add-resource - build-helper:add-test-resource add flag `<skipIfMissing>true|false<skipIfMissing>`. If this flag is set to true and a directory that should be added does not exist, skip it and do not add it to the build. This allows a multi module build to use these plugins unconditionally. E.g. ``` <plugin> <groupId>org.codehaus.mojo</groupId> <artifactId>build-helper-maven-plugin</artifactId> <executions> <execution> <id>kotlin</id> <goals> <goal>add-source</goal> </goals> <phase>generate-sources</phase> <configuration> <skipIfMissing>true</skipIfMissing> <sources> <source>${project.basedir}/src/main/kotlin</source> </sources> </configuration> </execution> </executions> </plugin> ``` can be configured unconditionally and only modules that actually have a `src/main/kotlin` folder will add this as a compile root.
Align with other plugins, use buildhelper prefix and plugin name.
slawekjaranowski
force-pushed
the
add-skip-missing
branch
from
November 20, 2023 19:22
885ed5a
to
0bef954
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add flag
<skipIfMissing>true|false<skipIfMissing>
. If this flag is setto true and a directory that should be added does not exist, skip it and
do not add it to the build. This allows a multi module build to use
these plugins unconditionally. E.g.
can be configured unconditionally and only modules that actually have a
src/main/kotlin
folder will add this as a compile root.