perf(webpack-bundler-runtime): bundle sdk into output to help treeshake #3519
+258
−290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 509ef7a The changes in this PR will be included in the next version bump. This PR includes changesets to release 29 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Nice improvement! |
|
amazing! |
| @@ -1,3 +1,3 @@ | |||
| export const FEDERATION_SUPPORTED_TYPES = ['script']; | |||
|
|
|||
| export { ENCODE_NAME_PREFIX } from '@module-federation/sdk'; | |||
| // export { ENCODE_NAME_PREFIX } from '@module-federation/sdk'; | |||
There was a problem hiding this comment.
do we wnt this commaned out?
There was a problem hiding this comment.
Yes, this constant is not be used yet
2heal1
force-pushed
the
perf/external-runtime-size
branch
from
473cbc3 to
d05a830
Compare
2heal1
commented
Feb 26, 2025
| @@ -6,7 +6,6 @@ import { | |||
| SEPARATOR, | |||
| MANIFEST_EXT, | |||
| } from './constant'; | |||
| import { logger } from './logger'; | |||
2heal1
commented
Feb 26, 2025
| @@ -37,10 +37,6 @@ | |||
| "import": "./dist/constant.esm.mjs", | |||
| "require": "./dist/constant.cjs.js" | |||
| }, | |||
| "./container": { | |||
zhoushaw
approved these changes
Feb 26, 2025
Merged
This was referenced Mar 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
bundle sdk into output to help treeshake
At past, the bundler runtime will external sdk , and when user set externalRuntime: true , it can not easy to shake the useless sdk code .
Example file: https://github.com/module-federation/core/tree/main/apps/manifest-demo/3009-webpack-provider
before: 34 kb
after: 14 kb
Related Issue
Types of changes
Checklist