Add pre-commit, replace isort and black with ruff #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwaskom
approved these changes
Feb 5, 2024
Comment on lines
-59
to
+62
| def __enter__(self) -> CTX: ... | ||
| def __enter__(self) -> CTX: | ||
| ... |
There was a problem hiding this comment.
I think we should be able to preserve the previous formatting for these stubs with ruff (based on astral-sh/ruff#6592); do you know why that's not happening here?
There was a problem hiding this comment.
It appears they only use that formatting for ellipsis blocks in .pyi files and not .py files 😢
freider
force-pushed
the
freider/ruff-pre-commit
branch
from
5b7eabf
to
d42d820
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got tired of forgetting to run ruff, black and isort before committing and then getting ci fails