Fixes #3179 : Add module for Java 21 tests. #3180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3180 +/- ##
=========================================
Coverage 85.50% 85.50%
Complexity 2914 2914
=========================================
Files 334 334
Lines 8864 8864
Branches 1097 1097
=========================================
Hits 7579 7579
Misses 995 995
Partials 290 290 ☔ View full report in Codecov by Sentry. |
|
Looks like the CI is flaky... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Java 21 module to be used for testing.
The current version of Gradle (8.4) doesn't yet support running on Java 21, but it does support compiling and testing using Java 21 through the use of toolchains (source). 8.5 will support running Java 21 (source), so the toolchain block can be removed then.
The test source directory is currently empty, apart from a
.gitkeepfile, but as soon as this PR is merged, it can be used for the tests from #3173 and #3167.There are no tests yet, but I did test the module by adding my test from #3173 (see top of that PR's description). The tests are ignored when running using Java 11, and correctly fail/pass when using Java 21.