Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove checks for unsupported Java version from unit tests #3150

Conversation

valfirst
Copy link
Contributor

Checklist

  • Read the contributing guide
  • PR should be motivated, i.e. what does it fix, why, and if relevant how
  • If possible / relevant include an example in the description, that could help all readers
    including project members to get a better picture of the change
  • Avoid other runtime dependencies
  • Meaningful commit history ; intention is important please rebase your commit history so that each
    commit is meaningful and help the people that will explore a change in 2 years
  • The pull request follows coding style
  • Mention Fixes #<issue number> in the description if relevant
  • At least one commit should mention Fixes #<issue number> if relevant

@valfirst valfirst force-pushed the remove-checks-for-unsupported-java-versions-from-unit-tests branch from 4f519f4 to 09de60e Compare October 18, 2023 20:33
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e736992) 85.53% compared to head (09de60e) 85.53%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #3150   +/-   ##
=========================================
  Coverage     85.53%   85.53%           
  Complexity     2912     2912           
=========================================
  Files           333      333           
  Lines          8856     8856           
  Branches       1095     1095           
=========================================
  Hits           7575     7575           
  Misses          993      993           
  Partials        288      288           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TimvdLippe TimvdLippe merged commit 73d6afc into mockito:main Oct 18, 2023
18 checks passed
@valfirst valfirst deleted the remove-checks-for-unsupported-java-versions-from-unit-tests branch October 18, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants