New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI on Android API level 33 for Java 11 compatibility testing #2899
Conversation
Codecov ReportBase: 85.65% // Head: 85.65% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #2899 +/- ##
=========================================
Coverage 85.65% 85.65%
Complexity 2847 2847
=========================================
Files 325 325
Lines 8623 8623
Branches 1060 1060
=========================================
Hits 7386 7386
Misses 964 964
Partials 273 273 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@TimvdLippe @reta as promised on #2893 (comment), still no inter-dependency with #2894. |
include: | ||
# Minimum supported | ||
- android-api: 26 | ||
android-image-type: default | ||
# Maximum available | ||
- android-api: 33 | ||
android-image-type: google_apis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Followup on #2893 (comment)
Goal
Adding API 33 to the testing suite, because it might bring significant changes which affect the internals of Mockito.
Additional changes
include:
because Google doesn't supplydefault
emulator images for 32 and 33. We found out the hard way here.mockito/.github/workflows/ci.yml
Line 146 in e978455
and
mockito/gradle/java-library.gradle
Lines 17 to 18 in e978455
Motivation
Android 13 / API 33 introduced Java 11 support:
https://developer.android.com/about/versions/13/features#core-libraries
https://android-developers.googleblog.com/2022/08/android-13-is-in-aosp.html
https://vived.io/android-gets-support-for-jdk-11-jvm-weekly-100/
Checklist
including project members to get a better picture of the change
commit is meaningful and help the people that will explore a change in 2 years
Fixes #<issue number>
in the description if relevantFixes #<issue number>
if relevant