Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI on Android API level 33 for Java 11 compatibility testing #2899

Merged
merged 3 commits into from Feb 4, 2023
Merged

CI on Android API level 33 for Java 11 compatibility testing #2899

merged 3 commits into from Feb 4, 2023

Conversation

TWiStErRob
Copy link
Contributor

@TWiStErRob TWiStErRob commented Feb 3, 2023

Followup on #2893 (comment)

Goal

Adding API 33 to the testing suite, because it might bring significant changes which affect the internals of Mockito.

Additional changes

Motivation

Android 13 / API 33 introduced Java 11 support:
https://developer.android.com/about/versions/13/features#core-libraries
https://android-developers.googleblog.com/2022/08/android-13-is-in-aosp.html
https://vived.io/android-gets-support-for-jdk-11-jvm-weekly-100/

Checklist

  • Read the contributing guide
  • PR should be motivated, i.e. what does it fix, why, and if relevant how
  • If possible / relevant include an example in the description, that could help all readers
    including project members to get a better picture of the change
  • Avoid other runtime dependencies
  • Meaningful commit history ; intention is important please rebase your commit history so that each
    commit is meaningful and help the people that will explore a change in 2 years
  • The pull request follows coding style
  • Mention Fixes #<issue number> in the description if relevant
  • At least one commit should mention Fixes #<issue number> if relevant

@codecov-commenter
Copy link

Codecov Report

Base: 85.65% // Head: 85.65% // No change to project coverage 👍

Coverage data is based on head (19059e6) compared to base (e978455).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2899   +/-   ##
=========================================
  Coverage     85.65%   85.65%           
  Complexity     2847     2847           
=========================================
  Files           325      325           
  Lines          8623     8623           
  Branches       1060     1060           
=========================================
  Hits           7386     7386           
  Misses          964      964           
  Partials        273      273           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TWiStErRob TWiStErRob marked this pull request as ready for review February 3, 2023 22:17
@TWiStErRob
Copy link
Contributor Author

@TimvdLippe @reta as promised on #2893 (comment), still no inter-dependency with #2894.

@TimvdLippe TimvdLippe merged commit b31b95a into mockito:main Feb 4, 2023
@TWiStErRob TWiStErRob deleted the android33 branch February 4, 2023 16:20
Comment on lines +98 to +104
include:
# Minimum supported
- android-api: 26
android-image-type: default
# Maximum available
- android-api: 33
android-image-type: google_apis
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants