Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes some mistakes and missing details in documentation #2889

Merged
merged 1 commit into from
Jan 29, 2023

Conversation

ascopes
Copy link
Contributor

@ascopes ascopes commented Jan 28, 2023

  • Makes static mock verification and construction initialisers into
    functional interfaces, and adds some missing documentation notes.
    Since Java 8 is the minimum target, this seems reasonable to
    include.
  • Fixes a number of grammar/spelling typos.
  • Replaces an instance of a JavaDoc comment suggesting to use a
    deprecated method with a reference to the suggested replacement.
  • Adds a note about supporting chaining of Spy with InjectMocks into
    the InjectMocks documentation.

- Makes static mock verification and construction initialisers into
  functional interfaces, and adds some missing documentation notes.
- Fixes a number of grammar/spelling typos.
- Replaces an instance of a JavaDoc comment suggesting to use a
  deprecated method with a reference to the suggested replacement.
- Adds a note about supporting chaining of Spy with InjectMocks into
  the InjectMocks documentation
@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2023

Codecov Report

Base: 85.81% // Head: 85.81% // No change to project coverage 👍

Coverage data is based on head (ef50622) compared to base (4775c67).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2889   +/-   ##
=========================================
  Coverage     85.81%   85.81%           
  Complexity     2844     2844           
=========================================
  Files           324      324           
  Lines          8601     8601           
  Branches       1059     1059           
=========================================
  Hits           7381     7381           
  Misses          947      947           
  Partials        273      273           
Impacted Files Coverage Δ
src/main/java/org/mockito/AdditionalAnswers.java 100.00% <ø> (ø)
src/main/java/org/mockito/ArgumentCaptor.java 100.00% <ø> (ø)
src/main/java/org/mockito/ArgumentMatcher.java 100.00% <ø> (ø)
src/main/java/org/mockito/ArgumentMatchers.java 99.01% <ø> (ø)
src/main/java/org/mockito/MockedStatic.java 100.00% <ø> (ø)
src/main/java/org/mockito/Mockito.java 96.55% <ø> (ø)
...rg/mockito/internal/debugging/LoggingListener.java 100.00% <ø> (ø)
...to/internal/stubbing/answers/CallsRealMethods.java 100.00% <ø> (ø)
...nal/stubbing/defaultanswers/ReturnsSmartNulls.java 96.96% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work. Thank you!

@TimvdLippe TimvdLippe merged commit 19ab3ea into mockito:main Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants