Deep Stubs Incompatible With Mocking Enum #3167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3167 +/- ##
============================================
- Coverage 85.34% 85.33% -0.01%
Complexity 2911 2911
============================================
Files 334 334
Lines 8866 8867 +1
Branches 1099 1101 +2
============================================
Hits 7567 7567
- Misses 1007 1008 +1
Partials 292 292 ☔ View full report in Codecov by Sentry. |
AndreasTu
force-pushed
the
fix_2984
branch
2 times, most recently
from
a02acef
to
10f8b9d
Compare
TimvdLippe
requested changes
Nov 26, 2023
src/main/java/org/mockito/internal/stubbing/defaultanswers/ReturnsDeepStubs.java
Outdated
Show resolved
Hide resolved
This was referenced Nov 27, 2023
|
@TimvdLippe I have fixed your remarks. And I have also moved the spotless code into |
TimvdLippe
requested changes
Nov 28, 2023
...ava21/src/test/java/org/mockito/internal/stubbing/answers/DeepStubReturnsEnumJava21Test.java
Outdated
Show resolved
Hide resolved
...ava21/src/test/java/org/mockito/internal/stubbing/answers/DeepStubReturnsEnumJava21Test.java
Outdated
Show resolved
Hide resolved
Mockito can't mock abstract enums in Java 15 or later because they are now marked as sealed. So Mockito reports that now with a better error message. If a deep stub returns an abstract enum, it uses in the error case now the first enum literal of the real enum. Fixes mockito#2984
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mockito can't mock abstract enums in Java 15 or later because they are now marked as sealed.
So Mockito reports that now with a better error message.
If a deep stub returns an abstract enum, it uses in the error case now the first enum literal of the real enum.
Fixes #2984