Fix regression - partial construction with trait methods #1403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Ant Weedon <81413869+adnweedon@users.noreply.github.com> Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
ghostwriter
added
Patch
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 1.6.x #1403 +/- ##
============================================
- Coverage 77.64% 77.58% -0.06%
- Complexity 1020 1021 +1
============================================
Files 76 76
Lines 2590 2592 +2
============================================
Hits 2011 2011
- Misses 579 581 +2
|
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
ghostwriter
deleted the
bugfix/issues-1402/partial-construction-with-trait-methods
branch
Merged
|
Thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch resolves #1402, via the following changes: