New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PHPUnit 10+ attributes #1386
Conversation
Fixes mockery#1359 While upgrading to PHPUnit 11 I noticed the following deprecation: Metadata in doc-comments is deprecated and will no longer be supported in PHPUnit 12. Update your test code to use attributes instead. If we add the attribute too, it stops complaining. So this most be a way to support PHPUnit 11 and older versions. If we ship this, we reduce a few errors. Most of the things just work fine.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 1.6.x #1386 +/- ##
=========================================
Coverage 78.03% 78.03%
Complexity 1021 1021
=========================================
Files 76 76
Lines 2632 2632
=========================================
Hits 2054 2054
Misses 578 578
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, @ruudk
Thank you.
GitHub is partially down right now, "degraded performance for Pull Requests and Actions:" https://www.githubstatus.com/incidents/wcl1sw4mzg60 I’ll restart GitHub Action and merge this once CI completes. |
for the record...
|
Thanks for fixing this! Looking forward to the release. 🚀 |
Fixes #1359
While upgrading to PHPUnit 11 I noticed the following deprecation:
Metadata in doc-comments is deprecated and will no longer be supported in PHPUnit 12. Update your test code to use attributes instead.
If we add the attribute too, it stops complaining. So this most be a way to support PHPUnit 11 and older versions.
If we ship this, we reduce a few errors. Most of the things just work fine.