Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor library/Mockery/Instantiator.php #1372

Merged
merged 1 commit into from Feb 29, 2024

Conversation

ghostwriter
Copy link
Member

This patch improves performance and readability without changing functionality.

  • library/Mockery/Instantiator.php

Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter ghostwriter added Performance for improvements or optimizations related to performance Refactor for code refactoring or restructuring without changes to functionality labels Feb 29, 2024
@ghostwriter ghostwriter added this to the 1.6.8 milestone Feb 29, 2024
@ghostwriter ghostwriter self-assigned this Feb 29, 2024
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 78.08%. Comparing base (4ef359c) to head (c07ba19).

Additional details and impacted files
@@             Coverage Diff              @@
##              1.6.x    #1372      +/-   ##
============================================
- Coverage     78.18%   78.08%   -0.11%     
  Complexity     1023     1023              
============================================
  Files            76       76              
  Lines          2650     2651       +1     
============================================
- Hits           2072     2070       -2     
- Misses          578      581       +3     
Files Coverage Δ
library/Mockery/Instantiator.php 29.41% <42.85%> (-4.59%) ⬇️

@ghostwriter ghostwriter merged commit 2b7ec13 into 1.6.x Feb 29, 2024
16 of 22 checks passed
@ghostwriter ghostwriter deleted the refactor/update-instantiator branch February 29, 2024 04:56
@ghostwriter ghostwriter mentioned this pull request Mar 12, 2024
@ghostwriter ghostwriter added the Patch Backwards compatible bug fixes and improvements label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Patch Backwards compatible bug fixes and improvements Performance for improvements or optimizations related to performance Refactor for code refactoring or restructuring without changes to functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant