Keep the file that caused an error for inspection #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ghostwriter
commented
Aug 7, 2023
ghostwriter
commented
- register a shutdown to perform the clean-up on error
- remove all the mocks we generated except the file that caused the last error, on exit.
ghostwriter
added
Patch
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 1.6.x #1325 +/- ##
============================================
- Coverage 77.88% 77.65% -0.23%
- Complexity 1014 1015 +1
============================================
Files 76 76
Lines 2595 2600 +5
============================================
- Hits 2021 2019 -2
- Misses 574 581 +7
|
ghostwriter
force-pushed
the
chore/refactor-require-loader-cleanup
branch
2 times, most recently
from
ce46bf7
to
169b37e
Compare
- register a shutdown to perform the clean-up on error - remove all the mocks we generated except the file that caused the last error, on exit. Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
ghostwriter
force-pushed
the
chore/refactor-require-loader-cleanup
branch
from
169b37e
to
1b7d230
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.