Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main branch into 1.6.x #1272

Merged
merged 2 commits into from Jun 6, 2023
Merged

Merge main branch into 1.6.x #1272

merged 2 commits into from Jun 6, 2023

Conversation

ghostwriter
Copy link
Member

This pull request addresses the need to correctly rebase the main branch into the 1.6.x branch prior to merging 1.6.x back into main.

Currently, the default branch main and the 1.6.x branch have diverged due to various commits and changes. To ensure a clean and seamless merge, it is essential to rebase the default branch onto 1.6.x, allowing the changes in the main branch to be incorporated into the 1.6.x branch while maintaining a linear commit history.

gmazzap and others added 2 commits May 9, 2023 09:51
`composer.json`'s branch alias for 1.6.x points to 1.4.x-dev version.

Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter ghostwriter added Patch Backwards compatible bug fixes and improvements Chore for non-functional changes or maintenance tasks such as code cleanup, formatting, or dependency upda labels Jun 6, 2023
@ghostwriter ghostwriter added this to the 1.6.2 milestone Jun 6, 2023
@ghostwriter ghostwriter self-assigned this Jun 6, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1272 (612a8f9) into 1.6.x (2eb7f1d) will increase coverage by 0.37%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff              @@
##              1.6.x    #1272      +/-   ##
============================================
+ Coverage     77.34%   77.71%   +0.37%     
- Complexity      993      996       +3     
============================================
  Files            74       74              
  Lines          2520     2526       +6     
============================================
+ Hits           1949     1963      +14     
+ Misses          571      563       -8     

see 8 files with indirect coverage changes

@ghostwriter ghostwriter merged commit ddc1683 into 1.6.x Jun 6, 2023
14 of 17 checks passed
This was referenced Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore for non-functional changes or maintenance tasks such as code cleanup, formatting, or dependency upda Patch Backwards compatible bug fixes and improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants