New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve ClassAttributesPass
for Dynamic Properties
#1244
Conversation
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## 1.6.x #1244 +/- ##
============================================
+ Coverage 77.39% 77.40% +0.01%
+ Complexity 994 993 -1
============================================
Files 74 74
Lines 2526 2523 -3
============================================
- Hits 1955 1953 -2
+ Misses 571 570 -1
|
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@lbrutti do you have any suggestions for improving this? I'm open to learning and collaborating. |
Sorry, wrong reaction: actually it was a composer thing. Let me remove the
thumb down.
…--
Inviato da Android
Il Dom 30 Apr 2023, 13:56 Nathanael Esayeas ***@***.***> ha
scritto:
lbrutti reacted with thumbs down emoji.
@lbrutti <https://github.com/lbrutti> do you have any suggestions for
improving this? I'm open to learning and collaborating.
—
Reply to this email directly, view it on GitHub
<#1244 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABIVSOT7GZUNHOIOTEZV6NTXDZHNDANCNFSM6AAAAAAXIVGPG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
No worries, thank you for letting me know. It's always good to figure out the root cause of an issue. If you have any questions or concerns in the future, please don't hesitate to reach out. |
This patch adds the
\AllowDynamicProperties
attribute on the mock object by default.Allows us to use
set
andandSet
to dynamically set properties on the object after the mock instance is created.DefinedTargetClass
Appends all additional attributes on PHP >= 8.0, via\ReflectionAttribute