Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring risky tests #1226

Merged
merged 10 commits into from Apr 14, 2023
Merged

Refactoring risky tests #1226

merged 10 commits into from Apr 14, 2023

Conversation

ghostwriter
Copy link
Member

This patch includes the following changes:

  • Updates failing and or risky tests

Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter
Copy link
Member Author

CI fails on PHP 8.2 due to the deprecation of dynamic properties. (WIP #1210)

@ghostwriter
Copy link
Member Author

Based on the changes in this pull request, it only cleans up the tests and not affecting the userland code in any way. https://github.com/mockery/mockery/pull/1226/files

Therefore, I am going to proceed and merge this pull request to continue building on top of this.

@ghostwriter ghostwriter merged commit bd8f225 into 1.5.x Apr 14, 2023
8 of 10 checks passed
@ghostwriter ghostwriter deleted the feature/refactoring-risky-tests branch April 15, 2023 00:53
@ghostwriter ghostwriter added this to the 1.5.2 milestone Apr 20, 2023
@ghostwriter ghostwriter mentioned this pull request Apr 22, 2023
@ghostwriter ghostwriter added Patch Backwards compatible bug fixes and improvements Chore for non-functional changes or maintenance tasks such as code cleanup, formatting, or dependency upda labels Apr 30, 2023
@ghostwriter ghostwriter self-assigned this May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore for non-functional changes or maintenance tasks such as code cleanup, formatting, or dependency upda Patch Backwards compatible bug fixes and improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant