Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MockeryExceptionInterface #1217

Merged
merged 7 commits into from Apr 30, 2023
Merged

Add MockeryExceptionInterface #1217

merged 7 commits into from Apr 30, 2023

Conversation

ghostwriter
Copy link
Member

If accepted, this patch adds.

  • MockeryExceptionInterface
  • Implements MockeryExceptionInterface on Mockery's Exception classes.

As of sebastianbergmann/phpunit@74ce5b6, all exceptions thrown in third-party subscribers are ignored.

This will allow us to register all of Mocker's Exceptions as PHPUnit failures via TestCase::registerFailureType() implemented in sebastianbergmann/phpunit@28766f5 for PHPUnit 10.1.

TestCase::registerFailureType(MockeryExceptionInterface::class) in MockeryTestCase

@ghostwriter
Create MockeryExceptionInterface.php
82f2c32 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter
Update Exception.php
6eacf66 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter
Update BadMethodCallException.php
ac2bf17 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter
Update InvalidArgumentException.php
92d05ab 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter
Update RuntimeException.php
51cca5b 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter
Update Exception.php
dd4113c 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter ghostwriter changed the base branch from master to 2.0.x April 10, 2023 19:37
@ghostwriter ghostwriter added this to the 2.0.0 milestone Apr 20, 2023
@ghostwriter ghostwriter added the Patch Backwards compatible bug fixes and improvements label Apr 30, 2023
@ghostwriter ghostwriter changed the title Add MockeryExceptionInterface for PHPUnit 10 Add MockeryExceptionInterface Apr 30, 2023
@ghostwriter ghostwriter changed the base branch from 2.0.x to 1.6.x April 30, 2023 19:56
@ghostwriter
Fix CS issue
311c24d 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter ghostwriter force-pushed the feature/add-mockery-exception-interface branch from 2c6f661 to 311c24d Compare April 30, 2023 19:59
@ghostwriter ghostwriter modified the milestones: 2.0.0, 1.6.0 Apr 30, 2023
@ghostwriter ghostwriter merged commit 213c4f9 into mockery:1.6.x Apr 30, 2023
7 checks passed
@ghostwriter ghostwriter deleted the feature/add-mockery-exception-interface branch April 30, 2023 20:03
@ghostwriter ghostwriter mentioned this pull request Apr 30, 2023
Merged
@ghostwriter ghostwriter added the Added for new features or functionality label May 1, 2023
@ghostwriter ghostwriter self-assigned this May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ghostwriter ghostwriter

Labels
Added for new features or functionality Patch Backwards compatible bug fixes and improvements
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ghostwriter