Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix function parameter default enum value #1199

Merged
merged 2 commits into from Apr 22, 2023
Merged

Fix function parameter default enum value #1199

merged 2 commits into from Apr 22, 2023

Conversation

murrant
Copy link
Contributor

@murrant murrant commented Nov 13, 2022

fixes #1198

@murrant murrant force-pushed the patch-1 branch 2 times, most recently from 2d8d869 to 5ce8705 Compare November 15, 2022 14:40
ghostwriter
ghostwriter reviewed Apr 22, 2023
View reviewed changes
Copy link
Member

@ghostwriter ghostwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,

my apologies for the delay in reviewing your pull request.

I'm going to rebase, finalize and merge this pull request.

Thank you for your patience and contribution.

@ghostwriter ghostwriter added this to the 1.6.0 milestone Apr 22, 2023
@ghostwriter ghostwriter changed the base branch from master to 1.6.x April 22, 2023 05:09
@ghostwriter ghostwriter force-pushed the patch-1 branch 2 times, most recently from b46ed7e to 84124ec Compare April 22, 2023 05:34
@murrant @ghostwriter
Fix function parameter default enum value
2eb7f1d 
fixes mockery#1198

Add tests
(add assertions to other test complaining about them too)
@ghostwriter
Update MethodDefinitionPass.php
b2d3e3b 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter ghostwriter merged commit b64176d into mockery:1.6.x Apr 22, 2023
5 of 6 checks passed
This was referenced Apr 22, 2023
Closed
Merged
@murrant murrant deleted the patch-1 branch April 23, 2023 18:26
@ghostwriter ghostwriter added Patch Backwards compatible bug fixes and improvements Changed for modifications to existing features or functionality labels Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghostwriter ghostwriter ghostwriter left review comments

Assignees
No one assigned
Labels
Changed for modifications to existing features or functionality Patch Backwards compatible bug fixes and improvements
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

Function with enum argument causes error
2 participants
@murrant @ghostwriter