Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IsEqual Argument Matcher #1276

Merged
merged 5 commits into from Jun 6, 2023
Merged

Add IsEqual Argument Matcher #1276

merged 5 commits into from Jun 6, 2023

Conversation

ghostwriter
Copy link
Member

@ghostwriter ghostwriter commented Jun 6, 2023

This pr adds an IsEqual Argument Matcher

Resolves #1268

Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter ghostwriter added enhancement new feature Patch Backwards compatible bug fixes and improvements Added for new features or functionality labels Jun 6, 2023
@ghostwriter ghostwriter added this to the 1.6.2 milestone Jun 6, 2023
@ghostwriter ghostwriter self-assigned this Jun 6, 2023
@ghostwriter ghostwriter changed the base branch from main to 1.6.x June 6, 2023 22:08
@codecov-commenter
Copy link

Codecov Report

Merging #1276 (62da68b) into 1.6.x (ecadf99) will decrease coverage by 0.05%.
The diff coverage is 50.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff              @@
##              1.6.x    #1276      +/-   ##
============================================
- Coverage     77.60%   77.56%   -0.05%     
- Complexity     1000     1002       +2     
============================================
  Files            75       76       +1     
  Lines          2532     2536       +4     
============================================
+ Hits           1965     1967       +2     
- Misses          567      569       +2     
Impacted Files Coverage Δ
library/Mockery/Matcher/IsEqual.php 50.00% <50.00%> (ø)

@ghostwriter ghostwriter merged commit 24f373d into 1.6.x Jun 6, 2023
8 of 9 checks passed
@ghostwriter ghostwriter deleted the feature/matcher/is-equal branch June 6, 2023 22:13
@ruudk
Copy link
Contributor

ruudk commented Jun 7, 2023

Thanks @ghostwriter 💙

Would it be possible to tag this?

@ghostwriter ghostwriter mentioned this pull request Jun 7, 2023
@ghostwriter ghostwriter added the Tests for updates or improvements to test suites label Jun 7, 2023
@oprypkhantc
Copy link
Contributor

@ghostwriter Would a PR adding a factory method for new IsEqual and IsSame matchers to Mockery be welcomed, similar to how Mockery::any() exist? i.e.

class Mockery {
    public static function equal($other) {
        return new IsEqual($other);
    }
}

@ghostwriter
Copy link
Member Author

Hey @oprypkhantc,

As you requested, I have included the factory methods for both IsEqual and IsSame in pull request #1336.

By the way, for future reference, please create a new issue so that we can keep old and new issues and requests separate.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added for new features or functionality enhancement new feature Patch Backwards compatible bug fixes and improvements Tests for updates or improvements to test suites
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What is the suggested replacement for Hamcrest IsEqual::equalTo
4 participants