CSI: Include test case with and without staging support

Signed-off-by: Olli Janatuinen <olli.janatuinen@gmail.com>

agent/csi/plugin/plugin.go

@@ -301,10 +301,14 @@ func (np *nodePlugin) NodePublishVolume(ctx context.Context, req *api.VolumeAssi
 
 	// some volumes do not require staging. we can check this by checkign the
 	// staging variable, or we can just see if there is a staging path in the
-	// map.
+	// map. if plugin does not support staging we can just ignore this check.
 	stagingPath := ""
-	if vs, ok := np.volumeMap[req.ID]; ok {
-		stagingPath = vs.stagingPath
+	if np.staging {
+		if vs, ok := np.volumeMap[req.ID]; ok {
+			stagingPath = vs.stagingPath
+		} else {
+			return status.Error(codes.FailedPrecondition, "volume not staged")
+		}
 	}
 
 	c, err := np.Client(ctx)

agent/csi/plugin/plugin_test.go

@@ -79,10 +79,11 @@ func TestNodeUnstageVolume(t *testing.T) {
 	require.NoError(t, err)
 }
 
-func TestNodePublishVolume(t *testing.T) {
+func TestNodePublishVolumeWithStaging(t *testing.T) {
 	plugin := "plugin-3"
 	node := "node-1"
 	nodePlugin := newVolumeClient(plugin, node)
+	nodePlugin.staging = true
 	s := &api.VolumeAssignment{
 		VolumeID: "vol3",
 		AccessMode: &api.VolumeAccessMode{
@@ -106,6 +107,28 @@ func TestNodePublishVolume(t *testing.T) {
 	require.NoError(t, err)
 }
 
+func TestNodePublishVolumeWithoutStaging(t *testing.T) {
+	plugin := "plugin-5"
+	node := "node-1"
+	nodePlugin := newVolumeClient(plugin, node)
+	nodePlugin.staging = false
+	s := &api.VolumeAssignment{
+		VolumeID: "vol3",
+		AccessMode: &api.VolumeAccessMode{
+			Scope:   api.VolumeScopeMultiNode,
+			Sharing: api.VolumeSharingOneWriter,
+			AccessType: &api.VolumeAccessMode_Mount{
+				Mount: &api.VolumeAccessMode_MountVolume{},
+			},
+		},
+		Driver: &api.Driver{
+			Name: plugin,
+		},
+	}
+	err := nodePlugin.NodePublishVolume(context.Background(), s)
+	require.NoError(t, err)
+}
+
 func TestNodeUnpublishVolume(t *testing.T) {
 	plugin := "plugin-4"
 	node := "node-1"