Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[25.0 backport] Makefile: generate-files: fix check for empty TMP_OUT #47586

Merged
merged 1 commit into from Mar 19, 2024

Commits on Mar 19, 2024

  1. Makefile: generate-files: fix check for empty TMP_OUT

    commit c655b7d added a check to make sure
    the TMP_OUT variable was not set to an empty value, as such a situation would
    perform an `rm -rf /**` during cleanup.
    
    However, it was a bit too eager, because Makefile conditionals (`ifeq`) are
    evaluated when parsing the Makefile, which happens _before_ the make target
    is executed.
    
    As a result `$@_TMP_OUT` was always empty when the `ifeq` was evaluated,
    making it not possible to execute the `generate-files` target.
    
    This patch changes the check to use a shell command to evaluate if the var
    is set to an empty value.
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    (cherry picked from commit 25c9e6e)
    Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
    thaJeztah authored and vvoland committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    02d4ee3 View commit details
    Browse the repository at this point in the history