Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[25.0 backport] c8d/pull: Progress fixes #47484

Merged
merged 4 commits into from
Mar 1, 2024
Merged

[25.0 backport] c8d/pull: Progress fixes #47484

merged 4 commits into from
Mar 1, 2024

Commits on Mar 1, 2024

  1. pkg/streamformatter: Make progressOutput concurrency safe 

    Sync access to the underlying `io.Writer` with a mutex.

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
(cherry picked from commit 5689dab)
Signed-off-by: Albin Kerouanton <albinker@gmail.com>
    @vvoland @akerouanton
    vvoland authored and akerouanton committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    8e3bcf1 View commit details
    Browse the repository at this point in the history

  2. c8d/pull: Emit Pulling fs layer 

    Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
(cherry picked from commit ff5f780)
Signed-off-by: Albin Kerouanton <albinker@gmail.com>
    @vvoland @akerouanton
    vvoland authored and akerouanton committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    2001813 View commit details
    Browse the repository at this point in the history

  3. c8d/pull: Don't emit Downloading with 0 progress 

    To align with the graphdrivers behavior and don't send unnecessary
progress messages.

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
(cherry picked from commit 14df52b)
Signed-off-by: Albin Kerouanton <albinker@gmail.com>
    @vvoland @akerouanton
    vvoland authored and akerouanton committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    97951c3 View commit details
    Browse the repository at this point in the history

  4. c8d/pull: Output truncated id for Pulling fs layer 

    All other progress updates are emitted with truncated id.

```diff
$ docker pull --platform linux/amd64 alpine
Using default tag: latest
latest: Pulling from library/alpine
-sha256:4abcf20661432fb2d719aaf90656f55c287f8ca915dc1c92ec14ff61e67fbaf8: Pulling fs layer
+4abcf2066143: Download complete
Digest: sha256:c5b1261d6d3e43071626931fc004f70149baeba2c8ec672bd4f27761f8e1ad6b
Status: Image is up to date for alpine:latest
docker.io/library/alpine:latest
```

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
(cherry picked from commit 16aa7dd)
Signed-off-by: Albin Kerouanton <albinker@gmail.com>
    @vvoland @akerouanton
    vvoland authored and akerouanton committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    be59afc View commit details
    Browse the repository at this point in the history