Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[25.0 backport] api: omit missing Created field from ImageInspect response #47451

Merged
merged 1 commit into from Feb 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 6 additions & 2 deletions api/swagger.yaml
Expand Up @@ -1742,9 +1742,13 @@ definitions:
Created:
description: |
Date and time at which the image was created, formatted in
[RFC 3339](https://www.ietf.org/rfc/rfc3339.txt) format with nano-seconds, or empty if the field was not set in the image config.
[RFC 3339](https://www.ietf.org/rfc/rfc3339.txt) format with nano-seconds.

This information is only available if present in the image,
and omitted otherwise.
type: "string"
x-nullable: false
format: "dateTime"
x-nullable: true
example: "2022-02-04T21:20:12.497794809Z"
Container:
description: |
Expand Down
5 changes: 4 additions & 1 deletion api/types/types.go
Expand Up @@ -72,7 +72,10 @@ type ImageInspect struct {

// Created is the date and time at which the image was created, formatted in
// RFC 3339 nano-seconds (time.RFC3339Nano).
Created string
//
// This information is only available if present in the image,
// and omitted otherwise.
Created string `json:",omitempty"`

// Container is the ID of the container that was used to create the image.
//
Expand Down
8 changes: 6 additions & 2 deletions docs/api/v1.44.yaml
Expand Up @@ -1742,9 +1742,13 @@ definitions:
Created:
description: |
Date and time at which the image was created, formatted in
[RFC 3339](https://www.ietf.org/rfc/rfc3339.txt) format with nano-seconds, or empty if the field was not set in the image config.
[RFC 3339](https://www.ietf.org/rfc/rfc3339.txt) format with nano-seconds.

This information is only available if present in the image,
and omitted otherwise.
type: "string"
x-nullable: false
format: "dateTime"
x-nullable: true
example: "2022-02-04T21:20:12.497794809Z"
Container:
description: |
Expand Down
5 changes: 2 additions & 3 deletions docs/api/version-history.md
Expand Up @@ -79,9 +79,8 @@ keywords: "API, Docker, rcli, REST, documentation"
`SecondaryIPv6Addresses` available in `NetworkSettings` when calling `GET /containers/{id}/json` are
deprecated and will be removed in a future release. You should instead look for the default network in
`NetworkSettings.Networks`.
* `GET /images/{id}/json` now responds with an empty `Created` field
(previously it was `0001-01-01T00:00:00Z`) if the `Created` field is missing
from the image config.
* `GET /images/{id}/json` omits the `Created` field (previously it was `0001-01-01T00:00:00Z`)
if the `Created` field is missing from the image config.

## v1.43 API changes

Expand Down