-
Notifications
You must be signed in to change notification settings - Fork 18.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: omit missing Created field from ImageInspect response #47450
Conversation
Signed-off-by: Bjorn Neergaard <bjorn.neergaard@docker.com>
This one probably will fail, asking for a change-log entry 😉 |
(added cherry-pick labels to follow-up #47387 👍) |
Can we still do this for v25 (as it already shipped), or is this considered a change to the API? |
Discussed in a call, and the missing omitempty was an oversight, so to not complicate things too much, it's better to include it than to have 3 variants. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Created
to0001-01-01T00:00:00Z
on older API versions #47374Set the
Created
field in image inspect toomitempty
so we don't return it when it is absent from the image config, as opposed to returning an empty string.