Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[25.0 backport] Set Created to 0001-01-01T00:00:00Z on older API versions #47387

Merged
merged 2 commits into from
Feb 14, 2024
Merged

[25.0 backport] Set Created to 0001-01-01T00:00:00Z on older API versions #47387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa3a64f
Set `Created` to `0001-01-01T00:00:00Z` on older API versions
tianon Feb 12, 2024
bb66c3c
api/history: Mention empty `Created`
vvoland Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions api/server/router/image/image_routes.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,12 @@ func (ir *imageRouter) getImagesByName(ctx context.Context, w http.ResponseWrite
version := httputils.VersionFromContext(ctx)
if versions.LessThan(version, "1.44") {
imageInspect.VirtualSize = imageInspect.Size //nolint:staticcheck // ignore SA1019: field is deprecated, but still set on API < v1.44.

if imageInspect.Created == "" {
// backwards compatibility for Created not existing returning "0001-01-01T00:00:00Z"
// https://github.com/moby/moby/issues/47368
imageInspect.Created = time.Time{}.Format(time.RFC3339Nano)
}
}
return httputils.WriteJSON(w, http.StatusOK, imageInspect)
}
Expand Down
2 changes: 1 addition & 1 deletion api/swagger.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1742,7 +1742,7 @@ definitions:
Created:
description: |
Date and time at which the image was created, formatted in
[RFC 3339](https://www.ietf.org/rfc/rfc3339.txt) format with nano-seconds.
[RFC 3339](https://www.ietf.org/rfc/rfc3339.txt) format with nano-seconds, or empty if the field was not set in the image config.
type: "string"
x-nullable: false
example: "2022-02-04T21:20:12.497794809Z"
Expand Down
2 changes: 1 addition & 1 deletion docs/api/v1.44.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1742,7 +1742,7 @@ definitions:
Created:
description: |
Date and time at which the image was created, formatted in
[RFC 3339](https://www.ietf.org/rfc/rfc3339.txt) format with nano-seconds.
[RFC 3339](https://www.ietf.org/rfc/rfc3339.txt) format with nano-seconds, or empty if the field was not set in the image config.
type: "string"
x-nullable: false
example: "2022-02-04T21:20:12.497794809Z"
Expand Down
3 changes: 3 additions & 0 deletions docs/api/version-history.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,9 @@ keywords: "API, Docker, rcli, REST, documentation"
`SecondaryIPv6Addresses` available in `NetworkSettings` when calling `GET /containers/{id}/json` are
deprecated and will be removed in a future release. You should instead look for the default network in
`NetworkSettings.Networks`.
* `GET /images/{id}/json` now responds with an empty `Created` field
(previously it was `0001-01-01T00:00:00Z`) if the `Created` field is missing
from the image config.

## v1.43 API changes

Expand Down