Allow to enable host loopback and use 10.0.2.2 to connect to the host (OPTIONALLY) #47352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhii-nakon
force-pushed
the
allow_host_loopback
branch
from
3c1b8bd
to
16ab43d
Compare
AkihiroSuda
reviewed
Feb 8, 2024
|
@AkihiroSuda Hello, can you look at it one more time? |
|
Looks good but please squash the commits |
serhii-nakon
force-pushed
the
allow_host_loopback
branch
from
69be0c0
to
86a0829
Compare
|
@AkihiroSuda OK, now it squashed. |
|
Thank you too |
|
Hello @AkihiroSuda does it will be merged or I need something change? |
|
@akerouanton @robmry PTAL |
robmry
approved these changes
Feb 27, 2024
… (OPTIONALLY) This should allow to enable host loopback by setting DOCKERD_ROOTLESS_ROOTLESSKIT_DISABLE_HOST_LOOPBACK to false, defaults true. Signed-off-by: serhii.n <serhii.n@thescimus.com>
serhii-nakon
force-pushed
the
allow_host_loopback
branch
from
86a0829
to
b649e27
Compare
|
@robmry I have updated "Description for the changelog" |
|
Thanks to all of you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
I allow to enable host loopback by setting DOCKERD_ROOTLESS_ROOTLESSKIT_DISABLE_HOST_LOOPBACK to false,
- How I did it
...
- How to verify it
Set DOCKERD_ROOTLESS_ROOTLESSKIT_DISABLE_HOST_LOOPBACK to false and it should allow connections to host by using 10.0.2.2 IP
- Description for the changelog
Allow to enable host loopback by setting DOCKERD_ROOTLESS_ROOTLESSKIT_DISABLE_HOST_LOOPBACK to false, defaults true. It allow to connect to host by using 10.0.2.2 IP
- A picture of a cute animal (not mandatory but encouraged)