Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[25.0 backport] Revert "daemon: automatically set network EnableIPv6 if needed" #47310

Merged
merged 2 commits into from
Feb 3, 2024
Merged

[25.0 backport] Revert "daemon: automatically set network EnableIPv6 if needed" #47310

merged 2 commits into from
Feb 3, 2024

Commits on Feb 2, 2024

  1. Revert "daemon: automatically set network EnableIPv6 if needed" 

    This reverts commit 5d5eeac.

Signed-off-by: Albin Kerouanton <albinker@gmail.com>
(cherry picked from commit c59e93a)
Signed-off-by: Albin Kerouanton <albinker@gmail.com>
    @akerouanton
    akerouanton committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    28c1a8b View commit details
    Browse the repository at this point in the history

  2. api/t/network: ValidateIPAM: ignore v6 subnet when IPv6 is disabled 

    Commit 4f47013 introduced a new validation step to make sure no
IPv6 subnet is configured on a network which has EnableIPv6=false.

Commit 5d5eeac then removed that validation step and automatically
enabled IPv6 for networks with a v6 subnet. But this specific commit
was reverted in c59e93a and now the error introduced by 4f47013
is re-introduced.

But it turns out some users expect a network created with an IPv6
subnet and EnableIPv6=false to actually have no IPv6 connectivity.
This restores that behavior.

Signed-off-by: Albin Kerouanton <albinker@gmail.com>
(cherry picked from commit e37172c)
Signed-off-by: Albin Kerouanton <albinker@gmail.com>
    @akerouanton
    akerouanton committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    0ccf1c2 View commit details
    Browse the repository at this point in the history