Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[25.0 backport] docs: remove dead links from api verison history #47296

Merged
merged 1 commit into from Feb 1, 2024
Merged

[25.0 backport] docs: remove dead links from api verison history #47296

merged 1 commit into from Feb 1, 2024

Conversation

dvdksn
Copy link
Contributor

@dvdksn dvdksn commented Feb 1, 2024

- What I did

The doc files for API versions 1.18-1.23 were deleted in d54be2e

The docs/api/version-history.md still contained links to those files, which were now broken.

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Beastie

@dvdksn
docs: remove dead links from api verison history
dd4de8f 
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
(cherry picked from commit 7f94acb)
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@thaJeztah thaJeztah added this to the 25.0.3 milestone Feb 1, 2024
thaJeztah
thaJeztah approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

Failure is unrelated (known flaky)

=== FAIL: amd64.integration.system TestDiskUsage/empty (0.00s)
    disk_usage_test.go:41: assertion failed: 
        --- du
        +++ →
          types.DiskUsage{
        - 	LayersSize: 4096,
        + 	LayersSize: 0,
          	Images:     {},
          	Containers: {},
          	... // 3 identical fields
          }
        
    --- FAIL: TestDiskUsage/empty (0.00s)

=== FAIL: amd64.integration.system TestDiskUsage (2.60s)

@thaJeztah thaJeztah merged commit 622e666 into moby:25.0 Feb 1, 2024
125 of 126 checks passed
@dvdksn dvdksn deleted the 25.0_backport_api_docs_broken_links branch February 1, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

@vvoland vvoland vvoland approved these changes

Assignees
No one assigned
Labels
area/api area/docs status/3-docs-review
Projects
None yet
Milestone
25.0.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dvdksn @thaJeztah @vvoland