Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[25.0 backport] image/save: Fix untagged images not present in index.json #47294

Merged
merged 3 commits into from Feb 5, 2024

Commits on Feb 1, 2024

  1. image/save: Fix untagged images not present in index.json

    Saving an image via digested reference, ID or truncated ID doesn't store
    the image reference in the archive. This also causes the save code to
    not add the image's manifest to the index.json.
    This commit explicitly adds the untagged manifests to the index.json if
    no tagged manifests were added.
    
    Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
    (cherry picked from commit d131f00)
    Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
    vvoland committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    78174d2 View commit details
    Browse the repository at this point in the history
  2. c8d/save: Handle digested reference same as ID

    When saving an image treat `image@sha256:abcdef...` the same as
    `abcdef...`, this makes it:
    
    - Not export the digested tag as the image name
    - Not try to export all tags from the image repository
    
    Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
    (cherry picked from commit 5e13f54)
    Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
    vvoland committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    225e043 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. integration/save: Add tests checking OCI archive output

    Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
    (cherry picked from commit 2ef0b53)
    Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
    vvoland committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    147b538 View commit details
    Browse the repository at this point in the history