Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[25.0 backport] gha: update actions to account for node 16 deprecation #47291

Merged
merged 13 commits into from Feb 1, 2024

Conversation

thaJeztah
Copy link
Member

thaJeztah and others added 13 commits February 1, 2024 12:33
Release notes:

- actions/checkout@v3.6.0...v4.1.1

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 0ffddc6)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
- full diff: actions/github-script@v6.4.1...v7.0.1

breaking changes: https://github.com/actions/github-script?tab=readme-ov-file#v7

> Version 7 of this action updated the runtime to Node 20
> https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#runs-for-javascript-actions
>
> All scripts are now run with Node 20 instead of Node 16 and are affected
> by any breaking changes between Node 16 and 20
>
> The previews input now only applies to GraphQL API calls as REST API previews
> are no longer necessary
> https://github.blog/changelog/2021-10-14-rest-api-preview-promotions/.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit fb53ee6)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
- full diff: actions/setup-go@v3.5.0...v5.0.0

v5

In scope of this release, we change Nodejs runtime from node16 to node20.
Moreover, we update some dependencies to the latest versions.

Besides, this release contains such changes as:

- Fix hosted tool cache usage on windows
- Improve documentation regarding dependencies caching

V4

The V4 edition of the action offers:

- Enabled caching by default
- The action will try to enable caching unless the cache input is explicitly
  set to false.

Please see "Caching dependency files and build outputs" for more information:
https://github.com/actions/setup-go#caching-dependency-files-and-build-outputs

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit e27a785)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
- Node 20 as default runtime (requires Actions Runner v2.308.0 or later)
- full diff: docker/metadata-action@v4.6.0...v5.5.0

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 00a2626)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
- Node 20 as default runtime (requires Actions Runner v2.308.0 or later)
- full diff: docker/setup-buildx-action@v2.10.0...v3.0.0

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit b7fd571)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
- Node 20 as default runtime (requires Actions Runner v2.308.0 or later)
- full diff docker/bake-action@v2.3.0...v4.1.0

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 4a1839e)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
- Node 20 as default runtime (requires Actions Runner v2.308.0 or later)
- full diff docker/setup-qemu-action@v2.2.0...v3.0.0

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 5d396e0)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
- Node 20 as default runtime (requires Actions Runner v2.308.0 or later)
- full diff docker/login-action@v2.2.0...v3.0.0

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 0825197)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
- Node 20 as default runtime (requires Actions Runner v2.308.0 or later)
- full diff: crazy-max/ghaction-github-runtime@v2.2.0...v3.0.0

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 3a81912)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
(cherry picked from commit a83557d)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
…t@v4

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
(cherry picked from commit 9babc02)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
(cherry picked from commit 5a3c463)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
(cherry picked from commit a2026ee)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

Failures are unrelated (restarted);

=== FAIL: amd64.integration.daemon TestLiveRestore/volume_references/local_volume_with_mount_options (2.29s)
    daemon_test.go:581: assertion failed: error is not nil: Error response from daemon: remove test-live-restore-volume-references-local: volume has active mounts
        --- FAIL: TestLiveRestore/volume_references/local_volume_with_mount_options (2.29s)

=== FAIL: amd64.integration.daemon TestLiveRestore/volume_references (20.82s)
    --- FAIL: TestLiveRestore/volume_references (20.82s)
=== FAIL: amd64.integration.daemon TestLiveRestore/volume_references/local_volume_with_mount_options (2.35s)
    daemon_test.go:581: assertion failed: error is not nil: Error response from daemon: remove test-live-restore-volume-references-local: volume has active mounts
        --- FAIL: TestLiveRestore/volume_references/local_volume_with_mount_options (2.35s)

=== FAIL: amd64.integration.daemon TestLiveRestore/volume_references (19.00s)
    --- FAIL: TestLiveRestore/volume_references (19.00s)

@thaJeztah thaJeztah merged commit 3e35844 into moby:25.0 Feb 1, 2024
126 checks passed
@thaJeztah thaJeztah deleted the 25.0_backport_update_actions branch February 1, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants