Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[25.0 backport] pkg/ioutils: Make subsequent Close attempts noop #47222

Merged
merged 1 commit into from Feb 1, 2024

Conversation

vvoland
Copy link
Contributor

@vvoland vvoland commented Jan 25, 2024

Turn subsequent Close calls into a no-op and produce a warning with an optional stack trace (if debug mode is enabled).

(cherry picked from commit 585d74b)

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Turn subsequent `Close` calls into a no-op and produce a warning with an
optional stack trace (if debug mode is enabled).

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
(cherry picked from commit 585d74b)
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
@vvoland vvoland added this to the 25.0.2 milestone Jan 25, 2024
@vvoland vvoland self-assigned this Jan 25, 2024
@vvoland vvoland changed the title pkg/ioutils: Make subsequent Close attempts noop [25.0 backport] pkg/ioutils: Make subsequent Close attempts noop Jan 25, 2024
@thaJeztah thaJeztah marked this pull request as draft January 25, 2024 14:22
@thaJeztah thaJeztah modified the milestones: 25.0.2, 25.0.3 Jan 31, 2024
@thaJeztah thaJeztah marked this pull request as ready for review February 1, 2024 03:18
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 5babfee into moby:25.0 Feb 1, 2024
125 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants