Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[24.0 backport] liverestore: Don't remove --rm containers on restart #46869

Merged
merged 2 commits into from Nov 30, 2023
Merged

[24.0 backport] liverestore: Don't remove --rm containers on restart #46869

merged 2 commits into from Nov 30, 2023

Commits on Nov 30, 2023

  1. liverestore: Don't remove --rm containers on restart 

    When live-restore is enabled, containers with autoremove enabled
shouldn't be forcibly killed when engine restarts.
They still should be removed if they exited while the engine was down
though.

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
(cherry picked from commit c5ea3d5)
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
    @vvoland
    vvoland committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    f0b5ca4 View commit details
    Browse the repository at this point in the history

  2. integration/TestLiveRestore: Wait for process to exit 

    Replace `time.Sleep` with a poll that checks if process no longer exists
to avoid possible race condition.

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
(cherry picked from commit 3a0af5a)
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
    @vvoland
    vvoland committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    d0b5a5a View commit details
    Browse the repository at this point in the history