Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0 backport] daemon: release sandbox even when NetworkDisabled #46702

Merged

Commits on Oct 23, 2023

  1. daemon: release sandbox even when NetworkDisabled

    When the default bridge is disabled by setting dockerd's `--bridge=none`
    option, the daemon still creates a sandbox for containers with no
    network attachment specified. In that case `NetworkDisabled` will be set
    to true.
    
    However, currently the `releaseNetwork` call will early return if
    NetworkDisabled is true. Thus, these sandboxes won't be deleted until
    the daemon is restarted. If a high number of such containers are
    created, the daemon would then take few minutes to start.
    
    See moby#42461.
    
    Signed-off-by: payall4u <payall4u@qq.com>
    Signed-off-by: Albin Kerouanton <albinker@gmail.com>
    (cherry picked from commit 9664f33)
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    payall4u authored and thaJeztah committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    05d95fd View commit details
    Browse the repository at this point in the history