[20.10 backport] daemon: handle EISDIR error from runtime #46694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neersighted
approved these changes
Oct 20, 2023
Go 1.20 made a change to the behaviour of package "os/exec" which was not mentioned in the release notes: golang/go@2b8f214 Attempts to execute a directory now return syscall.EISDIR instead of syscall.EACCESS. Check for EISDIR errors from the runtime and fudge the returned error message to maintain compatibility with existing versions of docker/cli when using a version of runc compiled with Go 1.20+. Signed-off-by: Cory Snider <csnider@mirantis.com> (cherry picked from commit 713e02e) Signed-off-by: Cory Snider <csnider@mirantis.com>
corhere
force-pushed
the
backport-20.10/runtime-eisdir
branch
from
a4b1d78
to
9794702
Compare
|
Failures on RS5 are the same as in #46693 (comment), and expected (should we add a Skip for RS5 in this branch?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.20 made a change to the behaviour of package "os/exec" which was not mentioned in the release notes:
golang/go@2b8f214
Attempts to execute a directory now return syscall.EISDIR instead of syscall.EACCESS. Check for EISDIR errors from the runtime and fudge the returned error message to maintain compatibility with existing versions of docker/cli when using a version of runc compiled with Go 1.20+.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)