Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport 24.0] daemon: fix under what conditions container's mac-address is applied #46478

Merged
merged 1 commit into from Sep 14, 2023

Commits on Sep 14, 2023

  1. daemon: fix under what conditions container's mac-address is applied

    The daemon would pass an EndpointCreateOption to set the interface MAC
    address if the network name and the provided network mode were matching.
    Obviously, if the network mode is a network ID, it won't work. To make
    things worse, the network mode is never normalized if it's a partial ID.
    
    To fix that: 1. the condition under what the container's mac-address is
    applied is updated to also match the full ID; 2. the network mode is
    normalized to a full ID when it's only a partial one.
    
    Signed-off-by: Albin Kerouanton <albinker@gmail.com>
    (cherry picked from commit 6cc6682)
    Signed-off-by: Albin Kerouanton <albinker@gmail.com>
    akerouanton committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    df983b7 View commit details
    Browse the repository at this point in the history