[24.0 backport] libcontainerd: work around exec start bug in c8d #45625
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker exec
make Docker unresponsive #45595It turns out that the unnecessary serialization removed in b752462 happened to work around a bug in containerd. When many exec processes are started concurrently in the same containerd task, it takes seconds to minutes for them all to start. Add the workaround back in, only deliberately this time.
(cherry picked from commit fb7ec15)
- What I did
- How I did it
✨ mutex ✨
- How to verify it
Takes ~3 seconds on my machine, compared to around a minute without the workaround.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)