Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[24.0 backport] vendor: github.com/containerd/go-runc v1.1.0 #45620

Merged
merged 1 commit into from
May 25, 2023
Merged

[24.0 backport] vendor: github.com/containerd/go-runc v1.1.0 #45620

merged 1 commit into from
May 25, 2023

Conversation

thaJeztah
Copy link
Member

full diff: containerd/go-runc@v1.0.0...v1.1.0

(cherry picked from commit 3512b04)

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah
vendor: github.com/containerd/go-runc v1.1.0
04eccf8 
full diff: containerd/go-runc@v1.0.0...v1.1.0

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 3512b04)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added this to the 24.0.2 milestone May 25, 2023
@thaJeztah
Copy link
Member Author

LOL, that error message .. I can relate so much with that; guess the engineer maintaining that got fed-up with questions / reports "it doesn't work!"

INFO: Installing go-winres version v0.3.0 in C:\gopath\bin
go: github.com/tc-hib/go-winres@v0.3.0: github.com/tc-hib/go-winres@v0.3.0: Get "https://proxy.golang.org/github.com/tc-hib/go-winres/@v/v0.3.0.info": dial tcp: lookup proxy.golang.org: getaddrinfow: This is usually a temporary error during hostname resolution and means that the local server did not receive a response from an authoritative server.
go-winres install failed...
At line:1 char:423

@thaJeztah thaJeztah marked this pull request as ready for review May 25, 2023 18:19
@neersighted neersighted merged commit 37bc639 into moby:24.0 May 25, 2023
102 checks passed
@thaJeztah thaJeztah deleted the 24.0_backport_update_go_runc_v1.1.0 branch May 25, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonistiigi tonistiigi tonistiigi approved these changes

@cpuguy83 cpuguy83 cpuguy83 approved these changes

@rumpl rumpl Awaiting requested review from rumpl

@tianon tianon Awaiting requested review from tianon

@corhere corhere Awaiting requested review from corhere

Assignees
No one assigned
Labels
status/2-code-review
Projects
None yet
Milestone
24.0.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thaJeztah @tonistiigi @cpuguy83 @neersighted