[backport 24.0] c8d/pull: Use same progress action as distribution #45602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker with containerd integration emits "Exists" progress action when a layer of the currently pulled image already exists. This is different from the non-c8d Docker which emits "Already exists". This makes both implementations consistent by emitting backwards compatible "Already exists" action. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com> (cherry picked from commit a7bc65f) Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
vvoland
added
area/api
status/2-code-review
area/images
containerd-integration
rumpl
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker with containerd integration emits "Exists" progress action when a layer of the currently pulled image already exists. This is different from the non-c8d Docker which emits "Already exists".
This makes both implementations consistent by emitting backwards compatible "Already exists" action.
(cherry picked from commit a7bc65f)
- How to verify it
- Description for the changelog
containerd integration: Make pull emit
Already existsprogress- A picture of a cute animal (not mandatory but encouraged)