[20.10 backport] awslogs: fix non-blocking log drop bug #45349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
changed the title
PettitWesley
commented
Apr 17, 2023
PettitWesley
force-pushed
the
awslogs-non-blocking-bug-20.10
branch
from
56a931b
to
6a2ad97
Compare
Previously, the AWSLogs driver attempted to implement non-blocking itself. Non-blocking is supposed to implemented solely by the Docker RingBuffer that wraps the log driver. Please see issue and explanation here: moby#45217 Signed-off-by: Wesley Pettit <wppttt@amazon.com> (cherry picked from commit c8f8d11)
PettitWesley
force-pushed
the
awslogs-non-blocking-bug-20.10
branch
from
6a2ad97
to
ad45ece
Compare
thaJeztah
approved these changes
Apr 17, 2023
corhere
approved these changes
Apr 18, 2023
neersighted
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the AWSLogs driver attempted to implement non-blocking itself. Non-blocking is supposed to
implemented solely by the Docker RingBuffer that
wraps the log driver.
Please see issue and explanation here:
#45217
Signed-off-by: Wesley Pettit wppttt@amazon.com
(cherry picked from commit c8f8d11)
This fix has been tested and proven to reduce log loss as shown here: #45217 (comment)
We agreed to backport it here, where it was merged into master: #45227 (comment)