-
Notifications
You must be signed in to change notification settings - Fork 18.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add no-new-privileges to SecurityOptions returned by /info #45320
Conversation
de96fa3
to
f9ed990
Compare
Looks like the docs on this field are a bit skimpy; Perhaps some of that was intentional (to prevent only partially documenting things), I think we could improve it though, if we know what things can appear there (we probably can). I'm good with keeping that for a follow-up, but I would suggest;
|
f9ed990
to
69ed548
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but left a comment about the function being exported 🙈
69ed548
to
620424f
Compare
Signed-off-by: Albin Kerouanton <albinker@gmail.com>
620424f
to
eb77382
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Super and working |
- What I did
Add no-new-privileges to SecurityOptions returned by /info
Partially fixes #45311.
- How to verify it
- Description for the changelog