Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.10] test containerd binary v1.7.0 #45140

Closed
wants to merge 1 commit into from
Closed

[20.10] test containerd binary v1.7.0 #45140

wants to merge 1 commit into from

Conversation

thaJeztah
Copy link
Member

Once we publish packages for containerd.io 1.7.0, existing daemons may also update to that version,
so opening this to test if CI is still happy with this version.

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah added this to the 20.10.24 milestone Mar 10, 2023
@thaJeztah
Copy link
Member Author

Ah, dang; won't work, because it requires Go 1.20 to build;

[2023-03-10T12:50:19.292Z] #37 [containerd 2/2] RUN --mount=type=cache,target=/root/.cache/go-build     --mount=type=cache,target=/go/pkg/mod     --mount=type=bind,src=hack/dockerfile/install,target=/tmp/install         PREFIX=/build /tmp/install/install.sh containerd
[2023-03-10T12:50:37.453Z] #37 437.6 # github.com/containerd/containerd/vendor/k8s.io/component-base/metrics
[2023-03-10T12:50:37.453Z] #37 437.6 vendor/k8s.io/component-base/metrics/registry.go:35:29: undefined: atomic.Bool

@thaJeztah
Copy link
Member Author

(or go1.19 maybe)

@thaJeztah
Copy link
Member Author

rebased on top of #44990

@thaJeztah thaJeztah force-pushed the 20.10_backport_containerd_binary_1.7.0_rc.3 branch from 174ee17 to a67c5b6 Compare March 10, 2023 16:45
@thaJeztah thaJeztah modified the milestones: 20.10.24, 20.10.25 Mar 30, 2023
@thaJeztah
[20.10] test containerd binary v1.7.0
bcce788 
Once we publish packages for containerd.io 1.7.0, existing daemons may also
update to that version, so opening this to test if CI is still happy with
this version.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the 20.10_backport_containerd_binary_1.7.0_rc.3 branch from a67c5b6 to bcce788 Compare April 12, 2023 22:06
@thaJeztah thaJeztah changed the title [20.10] test containerd binary v1.7.0-rc.3 [20.10] test containerd binary v1.7.0 Apr 12, 2023
@thaJeztah thaJeztah modified the milestones: 20.10.25, 20.10.26 Apr 27, 2023
@corhere corhere modified the milestones: 20.10.26, 20.10.27 Sep 27, 2023
@corhere corhere modified the milestones: 20.10.27, 20.10.28 Dec 1, 2023
@thaJeztah
Copy link
Member Author

closing as 20.10 reached EOL https://github.com/moby/moby/milestone/135

@thaJeztah thaJeztah closed this Jan 24, 2024
@thaJeztah thaJeztah deleted the 20.10_backport_containerd_binary_1.7.0_rc.3 branch January 24, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianon tianon Awaiting requested review from tianon tianon will be requested when the pull request is marked ready for review tianon is a code owner

Assignees
No one assigned
Labels
area/runtime area/testing status/2-code-review
Projects
None yet
Milestone
20.10.28
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thaJeztah @corhere