New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[23.0 backport] Upgrade containerd/fifo to v1.1.0 #45051
[23.0 backport] Upgrade containerd/fifo to v1.1.0 #45051
Conversation
Looks like we also need to backport #45001 https://github.com/moby/moby/actions/runs/4236309832/jobs/7363986803
I already had a cherry-pick label on that one, so let me open one |
opened #45056 |
146d119
to
ee7b91d
Compare
Rebased on top of HEAD; looks like this still isn't a clean cherry-pick. |
Looks like its That's one we should also consider backporting as it's fixing some potential panics and/or corruption if I'm not mistaken |
oh! Looks like I already marked that one for potential backporting. Let's do the drill; let me open a PR |
opened #45058 |
Signed-off-by: Cory Snider <csnider@mirantis.com> (cherry picked from commit d6c4e17) Signed-off-by: Cory Snider <csnider@mirantis.com> Signed-off-by: Bjorn Neergaard <bneergaard@mirantis.com>
ee7b91d
to
2c55b26
Compare
Rebased once again. |
Looks like validate is passing now 🤞 let's see if everything else goes green |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (assuming we get green now 😅)
All green 🎉 |
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)