Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.10 backport] builder: handle host-gateway with extra hosts #44650

Merged
merged 1 commit into from Dec 29, 2022
Merged

[20.10 backport] builder: handle host-gateway with extra hosts #44650

merged 1 commit into from Dec 29, 2022

Conversation

thaJeztah
Copy link
Member

(cherry picked from commit 521b8c0)

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@crazy-max @thaJeztah
builder: handle host-gateway with extra hosts
877a5e6 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
(cherry picked from commit 521b8c0)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added this to the 20.10.22 milestone Dec 15, 2022
@thaJeztah
Copy link
Member Author 

#20 108.6 curl: (35) OpenSSL SSL_connect: Connection reset by peer in connection to docker-images-prod.s3.dualstack.us-east-1.amazonaws.com:443

@thaJeztah thaJeztah modified the milestones: 20.10.22, 20.10.23 Dec 19, 2022
@thaJeztah
Copy link
Member Author

Failure on Windows is unrelated (known flaky test);

=== FAIL: github.com/docker/docker/integration-cli TestDockerSuite/TestStartReturnCorrectExitCode (14.81s)
    docker_cli_start_test.go:209: assertion failed: expected an error, got nil
    --- FAIL: TestDockerSuite/TestStartReturnCorrectExitCode (14.81s)

@thaJeztah
Copy link
Member Author

Bringing this one in 👍

@thaJeztah thaJeztah merged commit d46fe80 into moby:20.10 Dec 29, 2022
@thaJeztah thaJeztah deleted the 20.10_backport_builder_host_gateway branch December 29, 2022 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corhere corhere corhere approved these changes

@tonistiigi tonistiigi Awaiting requested review from tonistiigi tonistiigi is a code owner

Assignees
No one assigned
Labels
area/builder/buildkit Issues affecting buildkit area/builder kind/bugfix PR's that fix bugs status/2-code-review
Projects
None yet
Milestone
20.10.23
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thaJeztah @corhere @crazy-max