Fix Set interceptors #4528
Merged
Fix Set interceptors #4528
+69
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: aa4f5e6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@urugator / @mweststrate , could you, please, have a look at this PR? |
mweststrate
approved these changes
Mar 17, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code change checklist
/docs. For new functionality, at leastAPI.mdshould be updatedyarn mobx test:performance)I'm sorry for the missing related issue.
Just figured out that the
newValuereturned from theObservableSet's interceptor is ignored. The following code still uses the base value passed toadd()method. At a quick glance, theset()method of theObservableMapjust re-defines the value variable with thechange.newValue. So I've reproduced the logic and added coupe of tests.