Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: action transparently forwards toString of underlying function #3654

Merged
merged 2 commits into from
Nov 25, 2023

Conversation

ahoisl
Copy link
Contributor

@ahoisl ahoisl commented Mar 9, 2023

Code change checklist

  • Added/updated unit tests
  • Updated /docs. For new functionality, at least API.md should be updated
  • Verified that there is no significant performance drop (yarn mobx test:performance)

Fixes #3653 in that it transparently forwards the output of toString for functions wrapped in an action

@changeset-bot
Copy link

changeset-bot bot commented Mar 9, 2023

🦋 Changeset detected

Latest commit: f8f288a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mobx Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ahoisl ahoisl force-pushed the fix/ActionTransparentToString branch from 5b8a112 to f8f288a Compare March 10, 2023 11:23
@mweststrate mweststrate merged commit 86616c1 into mobxjs:main Nov 25, 2023
@github-actions github-actions bot mentioned this pull request Nov 25, 2023
@ahoisl ahoisl deleted the fix/ActionTransparentToString branch November 25, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

action does not forward underlying function's toString
2 participants