Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): remove workaround from labeler which broke validation #11401

Merged
merged 2 commits into from Mar 26, 2023
Merged

fix(ci): remove workaround from labeler which broke validation #11401

merged 2 commits into from Mar 26, 2023

Conversation

Swiftb0y
Copy link
Member

We should stop using their main branch and pin a version instead. Unfortunately they have not tagged a version which includes the fix yet.

@Swiftb0y Swiftb0y changed the base branch from main to 2.3 March 23, 2023 18:42
@Swiftb0y
Copy link
Member Author

Not sure why the check is still failing...

@Swiftb0y Swiftb0y force-pushed the fix/pr-labeller branch 2 times, most recently from e47f903 to b406cd6 Compare March 23, 2023 19:54
@Swiftb0y Swiftb0y force-pushed the fix/pr-labeller branch 2 times, most recently from 37508f3 to 08b2cd2 Compare March 23, 2023 20:18
@Swiftb0y
Copy link
Member Author

I have no idea what broke. I give up.

@fwcd
Copy link
Member

fwcd commented Mar 24, 2023 •
edited

I think the check is failing since the PR labeler always runs in the base of the PR (due to using the pull_request_target trigger), so you'd need to merge it first for the updated YAML to take effect.

@Holzhaus
Copy link
Member

We should stop using their main branch and pin a version instead. Unfortunately they have not tagged a version which includes the fix yet.

I'm pretty sure you can also use a specific commit directly, without having to wait for a tagged version.

@Swiftb0y
Copy link
Member Author

Thank you both for your comments. I pinned a specific commit now and I created a test PR that verify that this works. See this run: https://github.com/Swiftb0y/mixxx/actions/runs/4520806107/jobs/7962155324

@Swiftb0y
Copy link
Member Author

I'm taking the liberty to merge my own PR now since this is really just a simple fix to our CI.

@Swiftb0y Swiftb0y merged commit 9db1ac1 into mixxxdj:2.3 Mar 26, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fwcd fwcd fwcd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Swiftb0y @fwcd @Holzhaus